Loading...
Loading...
Compare original and translation side by side
$ARGUMENTS$ARGUMENTSplans/detector-refactor/review-plan$ARGUMENTS$ARGUMENTSplans/detector-refactor/review-planTaskListTaskGetpendingin_progressTask 1: Read the master plan
Task 2: Read all phase files and extract metadata
Task 3: Build dependency graph
Task 4: Assess data flow consistency
Task 5: Evaluate phase ordering
Task 6: Identify stale artifacts
Task 7: Cross-check "Done" phases against codebase
Task 8: Assess risk for pending phases
Task 9: Write audit report
Task 10: Return summaryin_progresscompletedTaskListTaskGetpendingin_progressTask 1: 读取主计划
Task 2: 读取所有阶段文件并提取元数据
Task 3: 构建依赖关系图
Task 4: 评估数据流一致性
Task 5: 评估阶段排序合理性
Task 6: 识别陈旧工件
Task 7: 对照代码库交叉检查“已完成”阶段
Task 8: 评估待处理阶段的风险
Task 9: 撰写审计报告
Task 10: 返回总结in_progresscompleted/review-plan| Problem | How It Manifests | Cost If Missed |
|---|---|---|
| Circular dependencies | Phase A waits for B, B waits for A — deadlock | Implementation stalls, requires plan restructuring |
| Missing dependencies | Phase 5 uses a table from Phase 3 but doesn't declare it | Phase 5 fails at runtime, debugging time wasted |
| Wrong ordering | Consumer phase runs before its data producer | Code compiles but crashes, phase must be re-sequenced |
| Stale artifacts | plan.md says "Done" but phase file says "Pending" | |
| "Done" phase not actually done | Phase marked complete but deliverables missing from codebase | Downstream phases build on a false foundation |
/implement/review-plan| 问题类型 | 表现形式 | 遗漏后的代价 |
|---|---|---|
| 循环依赖 | 阶段A等待阶段B,阶段B等待阶段A——形成死锁 | 实施停滞,需要重新调整计划结构 |
| 缺失依赖 | 阶段5使用阶段3生成的表,但未声明该依赖 | 阶段5在运行时失败,浪费调试时间 |
| 排序错误 | 消费阶段在数据生成阶段之前运行 | 代码可编译但会崩溃,必须重新排序阶段 |
| 陈旧工件 | plan.md显示“已完成”但阶段文件显示“待处理” | |
| “已完成”阶段未实际完成 | 阶段标记为已完成,但代码库中缺少交付物 | 下游阶段基于错误的基础进行构建 |
/implementreviews/planning/{plan-folder}/reviews/planning/flow-audit.mdplans/250202-voice-assistant/reviews/planning/flow-audit.mdplans/250202-api-refactor/reviews/planning/flow-audit.mdreviews/planning/Note: Per-phase template/codebase reviews go in the same folder — see. Code/implementation reviews go in/review-plan— seereviews/code/./code-review
reviews/planning/{plan-folder}/reviews/planning/flow-audit.mdplans/250202-voice-assistant/reviews/planning/flow-audit.mdplans/250202-api-refactor/reviews/planning/flow-audit.mdreviews/planning/注意: 单阶段模板/代码库审核报告放在同一文件夹——详见。代码/实施审核报告放在/review-plan——详见reviews/code/。/code-review
{plan-folder}/plan.md{plan-folder}/plan.md{plan-folder}/phase-*.md| Field | Where to Find |
|---|---|
| Phase number | Filename |
| Title | Frontmatter |
| Status | Frontmatter |
| Dependencies | Frontmatter |
| What it produces | Overview section |
| What it consumes | "How This Phase Fits" or "Prerequisites" sections |
| Key files it targets | Implementation steps (file paths mentioned) |
{plan-folder}/phase-*.md| 字段 | 查找位置 |
|---|---|
| 阶段编号 | 文件名 |
| 标题 | 前置元数据 |
| 状态 | 前置元数据 |
| 依赖项 | 前置元数据 |
| 产出物 | 概述部分 |
| 消耗物 | “本阶段的定位”或“先决条件”部分 |
| 目标关键文件 | 实施步骤中提及的文件路径 |
echo '{"cwd":"."}' | uv run $CLAUDE_PROJECT_DIR/.claude/hooks/validators/validate_no_placeholders.py \
--directory {plan-folder} --extension .md[To be detailed]TBDecho '{"cwd":"."}' | uv run $CLAUDE_PROJECT_DIR/.claude/hooks/validators/validate_no_placeholders.py \
--directory {plan-folder} --extension .md[To be detailed]TBDdependencies:| Issue Type | How to Detect |
|---|---|
| Circular dependencies | Phase A depends on B, B depends on A (directly or transitively) |
| Missing dependencies | Phase X uses output from Phase Y but doesn't list Y in dependencies |
| Unnecessary dependencies | Phase X lists Phase Y but doesn't actually use any of Y's output |
| Orphaned phases | Phase exists but no other phase depends on it AND it doesn't depend on anything |
| Dependency on deprecated phase | A phase depends on a phase marked |
dependencies:| 问题类型 | 检测方式 |
|---|---|
| 循环依赖 | 阶段A依赖阶段B,阶段B依赖阶段A(直接或间接) |
| 缺失依赖 | 阶段X使用阶段Y的输出,但未在依赖项中列出Y |
| 不必要依赖 | 阶段X列出阶段Y,但未实际使用Y的任何输出 |
| 孤立阶段 | 阶段存在,但没有其他阶段依赖它,且它不依赖任何其他阶段 |
| 依赖已弃用阶段 | 某阶段依赖标记为 |
| Artifact | How to Find |
|---|---|
| Deprecated phase files | |
| Duplicate phase numbers | Multiple files with same |
| Broken inter-phase links | |
| Renumbered but not updated | Phase file title says "Phase 17" but filename says |
| Phase table mismatches | plan.md phase table lists a phase title/file that doesn't match the actual file |
| Stale status | plan.md says "Done" but phase file says "Pending" (or vice versa) |
| 工件类型 | 查找方式 |
|---|---|
| 已弃用阶段文件 | 前置元数据中 |
| 重复阶段编号 | 多个文件使用相同的 |
| 损坏的阶段间链接 | |
| 重新编号但未更新 | 阶段文件标题显示“阶段17”但文件名为 |
| 阶段表不匹配 | plan.md的阶段表列出的阶段标题/文件与实际文件不符 |
| 状态不一致 | plan.md显示“已完成”但阶段文件显示“待处理”(反之亦然) |
{plan-folder}/reviews/code/phase-{NN}.md{plan-folder}/reviews/code/phase-{NN}.md| Risk Factor | High Risk | Low Risk |
|---|---|---|
| Dependencies | Depends on phases with known issues | Dependencies are clean and verified |
| File targets | References files that don't exist or are uncertain | Targets well-known, stable files |
| Scope | Touches many files across many directories | Focused on 1-2 files |
| Pattern clarity | Introduces new patterns not seen in codebase | Follows established patterns from "Done" phases |
| Blocking | Many downstream phases depend on it | Few or no downstream dependencies |
| 风险因素 | 高风险 | 低风险 |
|---|---|---|
| 依赖项 | 依赖存在已知问题的阶段 | 依赖项清晰且已验证 |
| 目标文件 | 引用不存在或不确定的文件 | 目标为知名、稳定的文件 |
| 范围 | 涉及多个目录下的多个文件 | 仅聚焦1-2个文件 |
| 模式清晰度 | 引入代码库中未出现过的新模式 | 遵循“已完成”阶段的既定模式 |
| 阻塞性 | 许多下游阶段依赖它 | 很少或没有下游依赖 |
{plan-folder}/reviews/planning/flow-audit.mdreviews/planning/{plan-folder}/reviews/planning/flow-audit.mdreviews/planning/undefinedundefined| # | Issue | Phases Affected | Severity | Suggested Fix |
|---|---|---|---|---|
| 1 | ... | P05, P12 | High | ... |
| 序号 | 问题 | 受影响阶段 | 严重程度 | 建议修复方案 |
|---|---|---|---|---|
| 1 | ... | P05, P12 | 高 | ... |
| # | Issue | Phases Affected | Details |
|---|---|---|---|
| 1 | ... | ... | ... |
| 序号 | 问题 | 受影响阶段 | 详情 |
|---|---|---|---|
| 1 | ... | ... | ... |
| # | Issue | Current Order | Suggested Order | Rationale |
|---|---|---|---|---|
| 1 | ... | P12 after P11 | P12 before P11 | Loader should exist before orchestrator uses it |
| 序号 | 问题 | 当前顺序 | 建议顺序 | 理由 |
|---|---|---|---|---|
| 1 | ... | P12在P11之后 | P12在P11之前 | 加载器应在编排器使用前存在 |
| # | Artifact | Type | Location | Action Needed |
|---|---|---|---|---|
| 1 | ... | Deprecated file | phase-17-unit-tests-update.md | Delete or archive |
| 序号 | 工件 | 类型 | 位置 | 需执行操作 |
|---|---|---|---|---|
| 1 | ... | 已弃用文件 | phase-17-unit-tests-update.md | 删除或归档 |
| Phase | Claim Checked | Verified? | Notes |
|---|---|---|---|
| P01 | Summary table created | Yes/No | ... |
| P11 | Orchestrator loads summaries | Yes/No | ... |
| 阶段 | 验证的声明 | 是否验证通过? | 备注 |
|---|---|---|---|
| P01 | 创建了汇总表 | 是/否 | ... |
| P11 | 编排器加载汇总数据 | 是/否 | ... |
| Phase | Risk | Key Risk Factors | Recommendation |
|---|---|---|---|
| P12 | High | Depends on P11 which may have ordering issues | Review dependency direction |
| P14 | Medium | Modifies Edge Function with complex existing logic | Read function before implementing |
| 阶段 | 风险等级 | 关键风险因素 | 建议 |
|---|---|---|---|
| P12 | 高 | 依赖可能存在排序问题的P11 | 审查依赖方向 |
| P14 | 中 | 修改包含复杂现有逻辑的Edge Function | 实现前先阅读函数代码 |
undefinedundefinedTaskListin_progressTaskGet {id}TaskList → find in_progress or first pending → TaskGet → continue work → TaskUpdate (completed) → next taskTaskListin_progressTaskGet {id}TaskList → 找到in_progress或第一个pending任务 → TaskGet → 继续工作 → TaskUpdate(标记为completed)→ 下一个任务{plan-folder}/reviews/planning/flow-audit.md/review-plan/implement{plan-folder}/reviews/planning/flow-audit.md/review-plan/implementdependencies:dependencies: