Loading...
Loading...
MUST be used whenever writing or replying to anything on GitHub - issues, pull requests, discussions, review threads. Enforces technical brevity, bans AI execution diaries, report bloat, bot watermarks, and em dashes.
npx skill4agent add dvcrn/skills github-comment-qualityGitHub text is technical communication with reviewers and collaborators, not an internal scratchpad, proof-of-work ledger, or bot execution diary.
Fixes #72
## Summary
- Initialize upstream MCP servers concurrently during startup rather than serially.
- Bounds startup latency to the slowest single upstream server.
## Changes
- Launch each configured upstream in its own goroutine and merge results deterministically by sorted server name.
- Retain child process handles to ensure clean process termination on shutdown.
## Verification
- Added unit tests for concurrent launch timing and deterministic tool ordering.
- Local benchmark: 9 upstreams initialize in 9.7s (down from 31.1s serial).
- `go test -race ./...` passes.Ran both humanizer and comment-and-documentation-quality skills on the guide. Flagged bold-spam (§15), announcing the next point (§28), repetition (§11), and stripped em dashes under Anti-Pattern 1 in commit 7dfe483...Updated in 7dfe483. Removed the MCP server comparison and tightened the wording. Build and tests pass.The URL split was my mistake. I carried over the Home Assistant case where aiohttp 404s on the slash variant, and assumed the same applied here without checking. Reverted in b64a2fd...Reverted the URL change and restored the test connection step in b64a2fd. The HTTP endpoint on 27123 remains the default.Fair hit on all three. You are right that I argued the point instead of doing it, and that citing other guides was the wrong move.Updated in 74f9283. Removed all em dashes across the guides and tightened the setup instructions._Generated by Claude Code__Reviewed by OpenAI Codex_Fixed the typo in 3a1b2c3.\n\n---\n_Generated by Claude Code_Fixed the typo in 3a1b2c3.go testI merged this branch onto main in a throwaway worktree and verified it locally:
$ go test -race ./...
ok github.com/dvcrn/mcpnest/internal/app 7.846sVerified locally with go test -race ./...Fixed the query parameter in 4b5c6d7. Also noticed that GitHub Actions CI configuration in .github/workflows/ci.yml is missing a Go cache step, which might slow down builds.Fixed the query parameter in 4b5c6d7. Tests pass.I did not touch the older guides beyond the dashes because antigravity-sync-macos is 162 words and reads thin.This change kills direct child processes on cancellation. Process-group cleanup for grandchildren is not yet handled and should be addressed in a follow-up.maywilltypicallyalways—–----verbose🚀💡✅Fix dirty state warning in AI dialogAI dialog shows stale warning after saveSupport concurrent upstream initializationfeat:fix: