Loading...
Loading...
Compare original and translation side by side
requesting-code-reviewrequesting-code-reviewQuestion: "Which implementation plan should I execute?"
Options:
- [list any plan directories you find in docs/implementation-plans/]
- "Let me provide the path"docs/implementation-plans/Question: "Which implementation plan should I execute?"
Options:
- [list any plan directories you find in docs/implementation-plans/]
- "Let me provide the path"docs/implementation-plans/undefinedundefined
The header includes the title (`# [Phase Title]`) and `**Goal:**` line. Extract the title for the task entry.
The grep output shows the task structure, e.g.:
Examples of headers you might see:
- `# Document Infrastructure Implementation Plan` — Phase 1 implied
- `# Phase 4: Link Resolution` — Phase number explicit
**Check for implementation guidance:**
After discovering phases, check if `.ed3d/implementation-plan-guidance.md` exists in the project root:
```bash
标题部分包含标题(`# [Phase Title]`)和`**Goal:**`行。提取标题用于任务条目。
grep的输出展示了任务结构,例如:
你可能看到的标题示例:
- `# Document Infrastructure Implementation Plan` — 隐含为第1阶段
- `# Phase 4: Link Resolution` — 明确标注阶段编号
**检查实施指南:**
发现阶段后,检查项目根目录下是否存在`.ed3d/implementation-plan-guidance.md`:
```bash
If the file exists, note its **absolute path** for use during code reviews. If it doesn't exist, proceed without it—do not pass a nonexistent path to reviewers.
**Check for test requirements:**
Check if `test-requirements.md` exists in the plan directory:
```bash
如果该文件存在,记录其**绝对路径**以便在代码审核时使用。如果不存在,则无需使用——不要将不存在的路径提供给审核人员。
**检查测试要求:**
检查计划目录下是否存在`test-requirements.md`:
```bash
If the file exists, note its **absolute path** for use during final review. The test requirements document specifies what automated tests must exist for each acceptance criterion.
如果该文件存在,记录其**绝对路径**以便在最终审核时使用。测试要求文档规定了每个验收标准必须具备的自动化测试。- [ ] Phase 1a: Read /absolute/path/to/phase_01.md — Document Infrastructure Implementation Plan
- [ ] Phase 1b: Execute tasks
- [ ] Phase 1c: Code review
- [ ] Phase 2a: Read /absolute/path/to/phase_02.md — API Integration
- [ ] Phase 2b: Execute tasks
- [ ] Phase 2c: Code review
...- [ ] 阶段1a:读取/absolute/path/to/phase_01.md — 文档基础设施实施计划
- [ ] 阶段1b:执行任务
- [ ] 阶段1c:代码审核
- [ ] 阶段2a:读取/absolute/path/to/phase_02.md — API集成
- [ ] 阶段2b:执行任务
- [ ] 阶段2c:代码审核
...task-implementor-fast<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-implementor-fast</parameter>
<parameter name="description">Implementing Phase X, Task Y: [description]</parameter>
<parameter name="prompt">
Implement Task N from the phase file.
Phase file: [absolute path to phase file]
Task number: N
Read the phase file and implement Task N (look for `<!-- START_TASK_N -->`).
Your job is to:
1. Read the phase file to understand context
2. Apply all relevant skills, such as (if available) ed3d-house-style:coding-effectively
3. Implement exactly what Task N specifies
4. Verify with tests/build/lint
5. Commit your work
6. Report back with evidence
Work from: [directory]
Provide complete report per your agent instructions.
</parameter>
</invoke><invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-implementor-fast</parameter>
<parameter name="description">Implementing Phase X, Subcomponent A (Tasks 3-5): [description]</parameter>
<parameter name="prompt">
Implement Subcomponent A (Tasks 3, 4, 5) from the phase file.
Phase file: [absolute path to phase file]
Tasks: 3, 4, 5 (look for `<!-- START_SUBCOMPONENT_A -->`)
Read the phase file and implement all tasks in this subcomponent.
Your job is to:
1. Read the phase file to understand context
2. Apply all relevant skills, such as (if available) ed3d-house-style:coding-effectively
3. Implement all tasks in sequence
4. Verify with tests/build/lint after completing all tasks
5. Commit your work (one commit per task, or logical commits)
6. Report back with evidence for each task
Work from: [directory]
Provide complete report covering all tasks.
</parameter>
</invoke>task-implementor-fast<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-implementor-fast</parameter>
<parameter name="description">实施阶段X,任务Y:[描述]</parameter>
<parameter name="prompt">
从阶段文件中实施任务N。
阶段文件:[阶段文件的绝对路径]
任务编号:N
读取阶段文件并实施任务N(查找`<!-- START_TASK_N -->`标记)。
你的职责是:
1. 读取阶段文件以了解上下文
2. 应用所有相关技能,例如(如果可用)ed3d-house-style:coding-effectively
3. 严格按照任务N的要求实施
4. 通过测试/构建/代码检查验证
5. 提交你的工作
6. 反馈验证证据
工作目录:[目录]
请按照你的Agent指令提供完整报告。
</parameter>
</invoke><invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-implementor-fast</parameter>
<parameter name="description">实施阶段X,子组件A(任务3-5):[描述]</parameter>
<parameter name="prompt">
从阶段文件中实施子组件A(任务3、4、5)。
阶段文件:[阶段文件的绝对路径]
任务:3、4、5(查找`<!-- START_SUBCOMPONENT_A -->`标记)
读取阶段文件并实施该子组件中的所有任务。
你的职责是:
1. 读取阶段文件以了解上下文
2. 应用所有相关技能,例如(如果可用)ed3d-house-style:coding-effectively
3. 按顺序实施所有任务
4. 完成所有任务后通过测试/构建/代码检查验证
5. 提交你的工作(每个任务提交一次,或按逻辑提交)
6. 反馈每个任务的验证证据
工作目录:[目录]
请提供涵盖所有任务的完整报告。
</parameter>
</invoke>requesting-code-review.ed3d/implementation-plan-guidance.mdTaskCreate: "Phase N fix [Critical]: <VERBATIM issue description from reviewer>"
TaskCreate: "Phase N fix [Important]: <VERBATIM issue description from reviewer>"
TaskCreate: "Phase N fix [Minor]: <VERBATIM issue description from reviewer>"
...one task per issue...
TaskCreate: "Phase N: Re-review after fixes"
TaskUpdate: set "Re-review" blocked by all fix taskstask-bug-fixer<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-bug-fixer</parameter>
<parameter name="description">Fixing review issues for Phase X</parameter>
<parameter name="prompt">
Fix issues from code review for Phase X.
Phase file: [absolute path to phase file]
Code reviewer found these issues:
[list all issues - Critical, Important, and Minor]
Read the phase file to understand the tasks and context.
Your job is to:
1. Understand root cause of each issue
2. Apply fixes systematically (Critical → Important → Minor)
3. Verify with tests/build/lint
4. Commit your fixes
5. Report back with evidence
Work from: [directory]
Fix ALL issues — including every Minor issue. The goal is ZERO issues on re-review.
Minor issues are not optional. Do not skip them.
</parameter>
</invoke>requesting-code-reviewrequesting-code-review.ed3d/implementation-plan-guidance.mdTaskCreate: "阶段N修复[严重]: <审核人员提供的完整问题描述>"
TaskCreate: "阶段N修复[重要]: <审核人员提供的完整问题描述>"
TaskCreate: "阶段N修复[次要]: <审核人员提供的完整问题描述>"
...每个问题对应一个任务...
TaskCreate: "阶段N:修复后重新审核"
TaskUpdate: 将“重新审核”任务设置为需等待所有修复任务完成task-bug-fixer<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-bug-fixer</parameter>
<parameter name="description">修复阶段X的审核问题</parameter>
<parameter name="prompt">
修复阶段X的代码审核问题。
阶段文件:[阶段文件的绝对路径]
代码审核人员发现以下问题:
[列出所有问题 - 严重、重要和次要]
读取阶段文件以了解任务和上下文。
你的职责是:
1. 理解每个问题的根本原因
2. 系统地修复问题(严重→重要→次要)
3. 通过测试/构建/代码检查验证
4. 提交修复内容
5. 反馈验证证据
工作目录:[目录]
修复所有问题——包括每个次要问题。目标是重新审核时零问题。
次要问题并非可选,请勿跳过。
</parameter>
</invoke>requesting-code-reviewed3d-extending-claude:project-claude-librarian<invoke name="Task">
<parameter name="subagent_type">ed3d-extending-claude:project-claude-librarian</parameter>
<parameter name="description">Updating project context after implementation</parameter>
<parameter name="prompt">
Review what changed during this implementation and update CLAUDE.md files if contracts or structure changed.
Base commit: <commit SHA at start of first phase>
Current HEAD: <current commit>
Working directory: <directory>
Follow the ed3d-extending-claude:maintaining-project-context skill to:
1. Diff against base to see what changed
2. Identify contract/API/structure changes
3. Update affected CLAUDE.md files
4. Commit documentation updates
Report back with what was updated (or that no updates were needed).
</parameter>
</invoke>ed3d-extending-claudeed3d-extending-claude:project-claude-librarian<invoke name="Task">
<parameter name="subagent_type">ed3d-extending-claude:project-claude-librarian</parameter>
<parameter name="description">实施完成后更新项目上下文</parameter>
<parameter name="prompt">
审核本次实施期间的变更,如果合约或结构发生变化则更新CLAUDE.md文件。
基准提交:<第一阶段开始时的提交SHA>
当前HEAD:<当前提交SHA>
工作目录:<目录>
按照ed3d-extending-claude:maintaining-project-context技能执行:
1. 与基准版本对比查看变更
2. 识别合约/API/结构变更
3. 更新受影响的CLAUDE.md文件
4. 提交文档更新
反馈更新内容(或说明无需更新)。
</parameter>
</invoke>ed3d-extending-claudeCode Review → Test Analysis (Coverage + Plan)代码审核 → 测试分析(覆盖率+计划)requesting-code-review{slug}.AC*requesting-code-review{slug}.AC*<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:test-analyst</parameter>
<parameter name="description">Analyzing test coverage and generating test plan</parameter>
<parameter name="prompt">
Analyze test implementation against acceptance criteria.
TEST_REQUIREMENTS_PATH: [absolute path to test-requirements.md]
WORKING_DIRECTORY: [project root]
BASE_SHA: [commit before first phase]
HEAD_SHA: [current commit]
Phase 1: Validate that automated tests exist for all acceptance criteria.
Phase 2: If coverage passes, generate human test plan using your analysis.
Return coverage validation result. If PASS, include the human test plan.
</parameter>
</invoke><invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-bug-fixer</parameter>
<parameter name="description">Adding missing test coverage</parameter>
<parameter name="prompt">
Add missing tests identified by the test analyst.
Missing coverage:
[list from analyst output]
For each missing test:
1. Read the acceptance criterion carefully
2. Create the test file at the expected location
3. Write tests that verify the criterion's actual behavior—not just code that passes, but code that would fail if the criterion weren't met
4. Run tests to confirm they pass
5. Commit the new tests
Work from: [directory]
</parameter>
</invoke>undefined<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:test-analyst</parameter>
<parameter name="description">分析测试覆盖率并生成测试计划</parameter>
<parameter name="prompt">
分析测试实施与验收标准的匹配情况。
TEST_REQUIREMENTS_PATH: [test-requirements.md的绝对路径]
WORKING_DIRECTORY: [项目根目录]
BASE_SHA: [第一阶段开始前的提交哈希]
HEAD_SHA: [当前提交哈希]
阶段1:验证所有验收标准都有对应的自动化测试。
阶段2:如果覆盖率通过,使用你的分析结果生成人工测试计划。
返回覆盖率验证结果。如果通过,包含人工测试计划。
</parameter>
</invoke><invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-bug-fixer</parameter>
<parameter name="description">添加缺失的测试覆盖率</parameter>
<parameter name="prompt">
添加测试分析人员识别出的缺失测试。
缺失的覆盖率:
[来自analyst输出的列表]
对于每个缺失的测试:
1. 仔细阅读验收标准
2. 在预期位置创建测试文件
3. 编写验证标准实际行为的测试——不仅是能通过的代码,还要编写在标准未满足时会失败的代码
4. 运行测试确认通过
5. 提交新测试
工作目录:[目录]
</parameter>
</invoke>undefined
Write the test plan content to `docs/test-plans/[impl-plan-dir-name].md`, then commit:
```bash
git add docs/test-plans/[impl-plan-dir-name].md
git commit -m "docs: add test plan for [feature name]"docs/test-plans/[impl-plan-dir-name].md
将测试计划内容写入`docs/test-plans/[impl-plan-dir-name].md`,然后提交:
```bash
git add docs/test-plans/[impl-plan-dir-name].md
git commit -m "docs: add test plan for [feature name]"docs/test-plans/[impl-plan-dir-name].mdfinishing-a-development-branchfinishing-a-development-branchYou: I'm using the `executing-an-implementation-plan` skill.
[Discover phases: phase_01.md, phase_02.md, phase_03.md]
[Read first 3 lines of each to get titles]
[Create tasks with TaskCreate:]
- [ ] Phase 1a: Read /path/to/phase_01.md — Project Setup
- [ ] Phase 1b: Execute tasks
- [ ] Phase 1c: Code review
- [ ] Phase 2a: Read /path/to/phase_02.md — Token Service
- [ ] Phase 2b: Execute tasks
- [ ] Phase 2c: Code review
- [ ] Phase 3a: Read /path/to/phase_03.md — API Middleware
- [ ] Phase 3b: Execute tasks
- [ ] Phase 3c: Code review
--- Phase 1 ---
[Mark 1a in_progress, read phase_01.md]
→ Contains 2 tasks: project setup, config files
[Mark 1a complete, 1b in_progress]
[Dispatch task-implementor-fast for Task 1]
→ Created package.json, tsconfig.json.
[Dispatch task-implementor-fast for Task 2]
→ Created config files. Build succeeds.
[Mark 1b complete, 1c in_progress]
[Use requesting-code-review skill for phase 1]
→ Zero issues.
[Mark 1c complete]
--- Phase 2 ---
[Mark 2a in_progress, read phase_02.md]
→ Contains 3 tasks: types, service, tests
[Mark 2a complete, 2b in_progress]
[Execute all 3 tasks...]
[Mark 2b complete, 2c in_progress]
[Use requesting-code-review skill for phase 2]
→ Important: 1, Minor: 1
→ Dispatch bug-fixer, re-review
→ Zero issues.
[Mark 2c complete]
--- Phase 3 ---
[Similar pattern...]
--- Finalize ---
[Invoke project-claude-librarian subagent]
→ Updated CLAUDE.md.
[Use requesting-code-review skill for final review]
→ All requirements met.
[Transitioning to finishing-a-development-branch]你:我正在使用`executing-an-implementation-plan`技能。
[发现阶段:phase_01.md, phase_02.md, phase_03.md]
[读取每个文件的前3行获取标题]
[使用TaskCreate创建任务:]
- [ ] 阶段1a:读取/path/to/phase_01.md — 项目设置
- [ ] 阶段1b:执行任务
- [ ] 阶段1c:代码审核
- [ ] 阶段2a:读取/path/to/phase_02.md — 令牌服务
- [ ] 阶段2b:执行任务
- [ ] 阶段2c:代码审核
- [ ] 阶段3a:读取/path/to/phase_03.md — API中间件
- [ ] 阶段3b:执行任务
- [ ] 阶段3c:代码审核
--- 阶段1 ---
[标记1a为in_progress,读取phase_01.md]
→ 包含2个任务:项目设置、配置文件
[标记1a为已完成,1b为in_progress]
[分配task-implementor-fast执行任务1]
→ 创建了package.json、tsconfig.json。
[分配task-implementor-fast执行任务2]
→ 创建了配置文件。构建成功。
[标记1b为已完成,1c为in_progress]
[使用requesting-code-review技能进行阶段1审核]
→ 无问题。
[标记1c为已完成]
--- 阶段2 ---
[标记2a为in_progress,读取phase_02.md]
→ 包含3个任务:类型定义、服务、测试
[标记2a为已完成,2b为in_progress]
[执行所有3个任务...]
[标记2b为已完成,2c为in_progress]
[使用requesting-code-review技能进行阶段2审核]
→ 重要问题:1,次要问题:1
→ 分配bug-fixer,重新审核
→ 无问题。
[标记2c为已完成]
--- 阶段3 ---
[类似流程...]
--- 最终完成 ---
[调用project-claude-librarian Subagent]
→ 更新了CLAUDE.md。
[使用requesting-code-review技能进行最终审核]
→ 所有要求均已满足。
[过渡到finishing-a-development-branch]| Excuse | Reality |
|---|---|
| "I'll read all phases upfront to understand the full picture" | No. Read one phase at a time. Context limits are real. |
| "I'll skip the read step, I remember what's in the file" | No. Always read just-in-time. Context may have been compacted. |
| "I'll review after each task to catch issues early" | No. Review once per phase. Task-level review wastes context. |
| "Context error on review, I'll skip the review" | No. Chunk the review into halves. Never skip review. |
| "Minor issues can wait" | No. Fix ALL issues including Minor. |
| 借口 | 实际情况 |
|---|---|
| “我提前读取所有阶段以了解全局” | 不行。一次读取一个阶段。上下文限制是真实存在的。 |
| “我跳过读取步骤,我记得文件内容” | 不行。始终按需读取。上下文可能已被压缩。 |
| “我在每个任务后进行审核以尽早发现问题” | 不行。每个阶段审核一次。任务级审核会浪费上下文。 |
| “审核时出现上下文错误,我跳过审核” | 不行。将审核拆分为两部分。永远不要跳过审核。 |
| “次要问题可以以后再处理” | 不行。修复所有问题包括次要问题。 |