swift-patterns
Review, refactor, or build SwiftUI features with correct state management, modern API usage, optimal view composition, and performance-conscious patterns. Prioritize native APIs, Apple design guidance, and testable code structure. This skill focuses on facts and best practices without enforcing specific architectural patterns.
Workflow Decision Tree
1) Review existing SwiftUI code
→ Read
references/workflows-review.md
for review methodology
- Check state management against property wrapper selection (see )
- Verify view composition and extraction patterns (see
references/view-composition.md
)
- Audit list performance and identity stability (see
references/lists-collections.md
)
- Validate modern API usage (see
references/modern-swiftui-apis.md
)
- Check async work patterns with .task (see
references/concurrency.md
)
- Verify navigation implementation (see )
- Use Review Response Template (below)
2) Refactor existing SwiftUI code
→ Read
references/workflows-refactor.md
for refactor methodology
- Extract complex views using playbooks (see
references/refactor-playbooks.md
)
- Migrate deprecated APIs to modern equivalents (see
references/modern-swiftui-apis.md
)
- Optimize performance hot paths (see
references/performance.md
)
- Restructure state ownership (see )
- Apply common patterns (see )
- Use Refactor Response Template (below)
3) Implement new SwiftUI features
- Design data flow first: identify owned vs injected state (see )
- Structure views for optimal composition (see
references/view-composition.md
)
- Use modern APIs only (see
references/modern-swiftui-apis.md
)
- Handle async work with .task modifier (see
references/concurrency.md
)
- Apply performance patterns early (see
references/performance.md
)
- Implement navigation flows (see )
4) Answer best practice questions
- Load relevant reference file(s) based on topic (see Reference Files below)
- Provide direct guidance with examples
If intent unclear, ask: "Do you want findings only (review), or should I change the code (refactor)?"
Response Templates
Review Response:
- Scope - What was reviewed
- Findings - Grouped by severity with actionable statements
- Evidence - File paths or code locations
- Risks and tradeoffs - What could break or needs attention
- Next steps - What to fix first or verify
Refactor Response:
- Intent + scope - What is being changed and why
- Changes - Bulleted list with file paths
- Behavior preservation - What should remain unchanged
- Next steps - Tests or verification needed
Quick Reference: Property Wrapper Selection
| Wrapper | Use When | Ownership |
|---|
| Internal view state (value type or class) | View owns |
| Child needs to modify parent's state | Parent owns |
| Injected object needing bindings | Injected |
| Read-only value from parent | Injected |
| + | Read-only value needing reactive updates | Injected |
Key rules:
- Always mark as (makes ownership explicit)
- Never use for passed values (accepts initial value only)
- Use with classes (not )
See
for detailed guidance and tradeoffs.
Quick Reference: Modern API Replacements
| Deprecated | Modern Alternative | Notes |
|---|
| | Supports dynamic type |
| .clipShape(.rect(cornerRadius:))
| More flexible |
| | Type-safe navigation |
| API | iOS 18+ |
| | Unless need location/count |
onChange(of:) { value in }
| onChange(of:) { old, new in }
or | Two or zero parameters |
| or layout APIs | Avoid hard-coded sizes |
See
references/modern-swiftui-apis.md
for complete migration guide.
Review Checklist
Use this when reviewing SwiftUI code:
State Management
Modern APIs
View Composition
Navigation & Sheets
Lists & Collections
Performance
Async Work
See reference files for detailed explanations of each item.
Constraints
- Swift/SwiftUI focus only - Exclude server-side Swift and UIKit unless bridging required
- No Swift concurrency patterns - Use for SwiftUI async work
- No architecture mandates - Don't require MVVM/MVC/VIPER or specific structures
- No formatting/linting rules - Focus on correctness and patterns
- No tool-specific guidance - No Xcode, Instruments, or IDE instructions
- Citations allowed:
developer.apple.com/documentation/swiftui/
, developer.apple.com/documentation/swift/
All workflows must follow these constraints.
Philosophy
This skill focuses on facts and best practices from Apple's documentation:
- Modern APIs over deprecated ones
- Clear state ownership patterns
- Performance-conscious view composition
- Testable code structure
- No architectural mandates (MVVM/VIPER not required)
- Apple Human Interface Guidelines adherence
Reference Files
- - Review methodology and findings taxonomy
- - Refactor methodology and invariants
- - Step-by-step refactor guides
- - Property wrappers and ownership patterns
- - Navigation implementation patterns
- - View structure and extraction
- - Identity and ForEach patterns
- - Scroll handling and pagination
- - Async work with .task
- - Optimization strategies
- - Testing and dependency injection
- - Common SwiftUI patterns
- - Legacy API migration
code-review-refactoring.md
- Code quality checks