review-security

Compare original and translation side by side

🇺🇸

Original

English
🇨🇳

Translation

Chinese

Review Security (internal)

内部安全审核

Composed by
review-change
/
product-audit
within their conversation — on any agent, follow this file inline as the routed step. Findings only; never edits, never refactors.
由对话中的
review-change
/
product-audit
组合而成——针对任何agent,需按此文件中的步骤执行。仅输出审核发现;绝不修改、重构代码。

Scope

审核范围

The diff or path/glob the caller passes; default the current change vs the default branch. State the scope at the top of the returned table.
调用方传入的差异或路径/通配符;默认对比当前变更与默认分支。需在返回表格顶部明确说明审核范围。

Checklist (evaluate EVERY item — none is optional; n/a must be stated)

检查清单(需评估每一项——无可选项;不适用项必须注明)

✓ No secrets/credentials/tokens in code, config, tests, or fixtures (grep the diff for key-like strings) ✓ Every external input on the changed paths is validated/sanitized before use ✓ No injection vectors (SQL/command/path/template) — parameterized/escaped, never concatenated ✓ AuthN/AuthZ enforced on every new/changed endpoint or entry point (cite where) ✓ No PII or secrets written to logs/error messages on the changed paths ✓ Webhooks/callbacks verify signatures before processing ✓ Rate limiting / abuse controls considered where a new public surface appears (n/a if none) ✓ New/updated dependencies pinned and free of known-critical advisories (state how you checked) ✓ Error responses don't leak stack traces or internal paths ✓ Unsafe deserialization / dynamic evaluation of untrusted data absent
✓ 代码、配置、测试或测试夹具中不存在密钥/凭证/令牌(使用grep检查差异中的类密钥字符串) ✓ 变更路径中的所有外部输入在使用前均经过验证/清理 ✓ 不存在注入漏洞(SQL/命令/路径/模板注入)——采用参数化/转义方式,绝不直接拼接 ✓ 所有新增/变更的端点或入口点均强制执行身份验证/授权(注明位置) ✓ 变更路径中不会将PII或密钥写入日志/错误信息 ✓ Webhook/回调在处理前会验证签名 ✓ 新增公共访问面时需考虑速率限制/滥用控制(无新增则标注不适用) ✓ 新增/更新的依赖已固定版本,且无已知严重安全漏洞(说明检查方式) ✓ 错误响应不会泄露堆栈跟踪或内部路径 ✓ 不存在对不可信数据的不安全反序列化/动态评估

Return exactly

返回格式严格遵循以下内容

REVIEW SECURITY — scope: <scope>

| # | Finding | Sev | Evidence | Suggested fix |
|---|---------|-----|----------|---------------|
| 1 | <what>  | critical|major|minor | <file:line> | <smallest action> |

Checklist: <n> evaluated, <n> pass, <n> findings, <n> n/a (<which + why>)
Summary: <1-2 sentences>
Decision: PASS | FAIL
FAIL if any critical or major finding is open; PASS otherwise. Minor findings never block — they route to the caller's triage step.
REVIEW SECURITY — scope: <scope>

| # | Finding | Sev | Evidence | Suggested fix |
|---|---------|-----|----------|---------------|
| 1 | <what>  | critical|major|minor | <file:line> | <smallest action> |

Checklist: <n> evaluated, <n> pass, <n> findings, <n> n/a (<which + why>)
Summary: <1-2 sentences>
Decision: PASS | FAIL
若存在任何严重(critical)或主要(major)问题则判定为FAIL;否则判定为PASS。次要(minor)问题不会阻塞流程——将转入调用方的分类处理步骤。

Done when

完成标准

  • Every checklist item was evaluated with evidence (file:line or command output) or explicitly marked n/a with the reason.
  • The fixed-format block above is returned — nothing more, nothing less — and no code was changed.
  • 每一项检查清单均已通过证据(文件:行号或命令输出)评估,或明确标注不适用并说明原因。
  • 返回上述固定格式内容——不多不少——且未修改任何代码。