sdlc-review
Compare original and translation side by side
🇺🇸
Original
English🇨🇳
Translation
ChineseSDLC Review Skill
SDLC审核Skill
Independently verify work handed from a Kanban implementation run to the review lane, then approve it, request changes, or escalate. This skill reviews the deliverable and its evidence; it does not take over the implementer's work.
独立验证从Kanban实施流程移交至审核环节的工作,然后进行批准、要求修改或升级处理。本Skill仅审核交付物及其佐证材料,不会接管实施人员的工作。
When to Use
使用场景
Use this skill when all of the following are true:
- the dispatcher spawned you for a task claimed from the lane;
review - an implementer submitted a handoff;
review_requested - the task needs an independent verdict before it can be completed.
Do not use it for a separate downstream review card. A downstream card is ordinary implementation work with a review-oriented specification and completes through its own lifecycle.
当以下所有条件均满足时使用本Skill:
- 调度程序为你分配了从环节领取的任务;
review - 实施人员提交了交接请求;
review_requested - 任务需要独立裁决才能完成。
不要用于单独的下游审核卡片。下游卡片是带有审核导向规范的常规实施工作,会通过自身生命周期完成。
Prerequisites
前置条件
- A Kanban worker context with the current task and run identifiers.
- Native Kanban tools: ,
kanban_show,kanban_comment,kanban_complete, andkanban_request_changes.kanban_block - Workspace access through ,
read_file, andsearch_fileswhen the deliverable is code.terminal - The task's original specification, acceptance criteria, handoff summary, and prior run history must be available through .
kanban_show
- 包含当前任务和流程标识符的Kanban工作环境;
- 原生Kanban工具:、
kanban_show、kanban_comment、kanban_complete和kanban_request_changes;kanban_block - 当交付物为代码时,可通过、
read_file和search_files访问工作区;terminal - 任务的原始需求、验收标准、交接摘要和过往流程记录必须可通过获取。
kanban_show
How to Run
运行方式
This skill is loaded automatically by the review dispatcher. Start with before inspecting files or choosing a verdict.
kanban_show- Read the task specification and the latest handoff.
review_requested - Inspect the actual deliverable and run relevant verification.
- Choose exactly one verdict: approve, request changes, or escalate.
- Record concrete evidence in the terminal Kanban transition.
本Skill由审核调度程序自动加载。在检查文件或选择裁决结果前,先调用。
kanban_show- 阅读任务需求和最新的交接内容;
review_requested - 检查实际交付物并执行相关验证;
- 选择且仅选择一种裁决结果:批准、要求修改或升级处理;
- 在终端的Kanban流转中记录具体佐证材料。
Quick Reference
速查指南
| Verdict | When | Final action |
|---|---|---|
| Approve | Acceptance criteria and verification pass | |
| Request changes | Correctable implementation defects remain | |
| Escalate | A human decision or external prerequisite is required | |
A requested-changes transition returns the task to its original implementer. When that implementer requests review again without naming a reviewer, the persisted reviewer provenance routes the re-review back to the same reviewer profile.
| 裁决结果 | 适用场景 | 最终操作 |
|---|---|---|
| 批准 | 验收标准和验证均通过 | |
| 要求修改 | 存在可修正的实施缺陷 | |
| 升级处理 | 需要人工决策或外部前置条件 | |
要求修改的流转会将任务退回给原实施人员。当该实施人员再次请求审核但未指定审核者时,留存的审核者来源信息会将复审任务分配给同一审核者角色。
Review Lenses
审核视角
Vary how you look at the work on each round instead of repeating the same inspection. Decorrelated lenses catch different defect classes: a cold read of the artifact surfaces design and correctness problems that the implementer's narrative would have framed away, execution surfaces claims that do not reproduce, and a strict contract audit surfaces quiet scope drift. Repeating the round-1 lens on round 3 mostly re-finds what round 1 already found.
Determine the current round from the history the task record already gives you: count the entries in the "Prior attempts on this task" section of your worker context (also visible as prior runs in ). The current review round is that count plus one. Round 1 therefore shows zero attempts; round 2 shows one; and so on.
changes_requestedkanban_showchanges_requested| Round | Lens | How to apply it |
|---|---|---|
| 1 | Artifact | Read the diff or deliverable cold, before the implementer's summary. Form an independent judgment, then compare it against the handoff narrative and investigate every mismatch. |
| 2 | Execution | Check out the work and actually run it via |
| 3+ | Contract | Re-read the ORIGINAL task body and acceptance criteria, then audit the deliverable strictly against them. Also verify that every item from every prior |
The baseline duties in the Procedure section still apply on every round; the lens sets which inspection you lead with and weight most heavily.
每次审核时更换审视工作的角度,而非重复相同的检查方式。不同的视角能发现不同类型的缺陷:对交付物的初次审视会暴露实施人员描述中未提及的设计和正确性问题;执行验证能发现无法复现的主张;严格的契约审核能发现隐蔽的范围偏差。在第三轮审核时重复第一轮的视角,大多只能发现第一轮已找到的问题。
从任务记录的历史信息中确定当前审核轮次:统计工作环境中“该任务的过往尝试”部分(也可通过查看过往流程)的条目数量。当前审核轮次为该数量加1。因此第一轮审核显示0次尝试;第二轮显示1次,以此类推。
kanban_showchanges_requestedchanges_requested| 轮次 | 视角 | 应用方式 |
|---|---|---|
| 1 | 交付物视角 | 在查看实施人员的摘要前,先直接阅读差异内容或交付物。形成独立判断后,再与交接描述对比,调查所有不符之处。 |
| 2 | 执行视角 | 通过 |
| 3+ | 契约视角 | 重新阅读原始任务内容和验收标准,然后严格对照审核交付物。同时验证每一轮过往 |
流程部分的基础职责在每一轮审核中均适用;视角决定了首先进行哪项检查以及重点关注的内容。
Lens variation for ad-hoc review fan-outs
临时多审核者场景的视角变化
The same principle applies outside the Kanban review lane. When spawning multiple parallel reviewers via , give each reviewer a different lens — one diff-only brief, one full-context brief, one checkout-and-run brief — rather than identical briefs. Identical briefs produce correlated verdicts and duplicate findings; varied briefs cover more defect classes for the same review spend.
delegate_task同一原则也适用于Kanban审核环节之外。当通过分配多个并行审核者时,应为每个审核者分配不同的视角——一个仅查看差异的任务brief、一个全上下文的任务brief、一个检出并运行的任务brief——而非相同的brief。相同的brief会产生趋同的裁决结果和重复的发现;不同的brief能在相同的审核成本下覆盖更多类型的缺陷。
delegate_taskProcedure
流程步骤
1. Orient from the durable task record
1. 从持久化任务记录中获取信息
Call and identify:
kanban_show- the original task body and acceptance criteria;
- the latest implementation summary and structured metadata;
- changed files, commit identifiers, and test evidence;
- comments and decisions from earlier runs;
- findings from prior review rounds.
Treat the handoff as a claim to verify, not as proof that the work is correct.
调用并确认:
kanban_show- 原始任务内容和验收标准;
- 最新的实施摘要和结构化元数据;
- 修改的文件、提交标识符和测试佐证;
- 过往流程中的评论和决策;
- 过往审核轮次的发现。
将交接内容视为需要验证的主张,而非工作已完成的证明。
2. Compare requested behavior with delivered behavior
2. 对比需求行为与交付行为
Map every acceptance criterion to concrete implementation or output evidence. Note omissions, changed semantics, and unrelated scope before deciding whether to run deeper checks.
For code work:
- Use and
read_fileto inspect the changed paths and their callers.search_files - Use to inspect the diff and run the project's existing focused tests, lint, type checks, or build commands.
terminal - Exercise the reported failure path and at least one ordinary control path when practical.
- Check error handling, edge cases, concurrency boundaries, data preservation, security boundaries, and cross-platform behavior relevant to the change.
- Confirm that tests assert behavior rather than merely snapshotting source text or constants.
For non-code work:
- Inspect the complete deliverable rather than only its summary.
- Check correctness, completeness, formatting, and provenance.
- Validate referenced URLs or external facts with the appropriate native tools when they affect the verdict.
将每一项验收标准映射到具体的实施或输出佐证。在决定是否进行更深入检查前,记录遗漏、语义变更和无关范围的内容。
对于代码类工作:
- 使用和
read_file检查修改的路径及其调用者;search_files - 使用查看差异并运行项目现有的聚焦测试、代码检查、类型检查或构建命令;
terminal - 在可行的情况下,测试报告的故障路径和至少一条常规控制路径;
- 检查与变更相关的错误处理、边缘情况、并发边界、数据保留、安全边界和跨平台行为;
- 确认测试是针对行为进行断言,而非仅快照源代码文本或常量。
对于非代码类工作:
- 检查完整的交付物,而非仅查看其摘要;
- 检查正确性、完整性、格式和来源;
- 当引用的URL或外部事实会影响裁决结果时,使用合适的原生工具进行验证。
3. Choose one verdict
3. 选择一种裁决结果
Approve
批准
Approve only when the acceptance criteria are satisfied and the evidence is sufficient. Call:
text
kanban_complete(
summary="Reviewed and approved. <what was verified>",
metadata={"review_outcome": "approved", "reviewer_checks": [...]}
)Include the exact checks that passed and any bounded caveat that does not block acceptance.
仅当验收标准满足且佐证充分时才批准。调用:
text
kanban_complete(
summary="已审核并批准。<验证内容>",
metadata={"review_outcome": "approved", "reviewer_checks": [...]}
)包含通过的具体检查内容以及任何不影响验收的有限说明。
Request changes
要求修改
Use this for specific, correctable defects. First record actionable findings:
text
kanban_comment(
task_id="<current-task-id>",
body="Changes requested:\n1. <file or artifact + defect>\n2. <required correction>",
)Then return the same task to its implementer:
text
kanban_request_changes(
reason="<concise summary of the required corrections>"
)State where the defect is, how it reproduces, why it violates the task, and what minimum outcome would resolve it. The transition does not use blocker recurrence accounting.
此选项适用于具体的、可修正的缺陷。首先记录可操作的发现:
text
kanban_comment(
task_id="<当前任务ID>",
body="要求修改:\n1. <文件或交付物 + 缺陷>\n2. <所需修正>",
)然后将同一任务退回给实施人员:
text
kanban_request_changes(
reason="<所需修正的简洁摘要>"
)说明缺陷位置、复现方式、违反任务的原因以及解决问题所需的最低结果。该流转不使用阻塞重复统计。
Escalate
升级处理
Use escalation only when the reviewer and implementer cannot resolve the problem without a human decision or external prerequisite:
text
kanban_block(
reason="escalation: <decision or prerequisite required>"
)Explain the blocked decision and the smallest information needed to continue.
仅当审核者和实施人员在没有人工决策或外部前置条件的情况下无法解决问题时,才使用升级处理:
text
kanban_block(
reason="escalation: <所需的决策或前置条件>"
)说明被阻塞的决策以及继续推进所需的最少信息。
4. Preserve role separation
4. 保持角色分离
Do not edit the implementation while acting as reviewer. Request changes and let the implementer produce the next candidate; then independently verify that candidate in the next review run.
作为审核者时,不要编辑实施内容。提出修改要求,让实施人员生成下一个候选版本;然后在下一轮审核中独立验证该候选版本。
Pitfalls
常见误区
- Rubber-stamping: A passing handoff summary is not independent evidence.
- Reviewer implementation: Editing the deliverable hides ownership and weakens the re-review boundary.
- Vague findings: “Needs work” does not give the implementer a reproducible correction target.
- Style-only blocking: Do not request changes for preference-level nits when behavior and repository standards are satisfied.
- Skipping prior rounds: Re-review must confirm both the requested corrections and preservation of previously passing behavior.
- Using blockers for ordinary rework: Correctable defects belong in ; reserve
kanban_request_changesfor genuine external blockers or human decisions.kanban_block - Completing without evidence: Every approval summary must name the checks or artifacts actually inspected.
- 橡皮图章式审核:通过的交接摘要并非独立佐证;
- 审核者代劳实施:编辑交付物会模糊职责归属,削弱复审边界;
- 模糊的发现:“需要改进”无法为实施人员提供可复现的修正目标;
- 仅因风格阻塞:当行为和仓库标准均满足时,不要因偏好性细节要求修改;
- 跳过过往轮次:复审必须同时确认已要求的修正内容和之前通过的行为是否保持不变;
- 用阻塞处理常规返工:可修正的缺陷应使用;将
kanban_request_changes保留给真正的外部阻塞或人工决策;kanban_block - 无佐证的批准:每一条批准摘要必须注明实际检查的内容或交付物。
Verification
验证步骤
Before submitting the verdict, confirm:
- was read for the current task and run.
kanban_show - Every acceptance criterion was mapped to evidence.
- The actual deliverable was inspected.
- Relevant focused checks were run or an explicit reason was recorded when execution was impossible.
- Prior requested changes were re-tested on re-review.
- Unrelated regressions and scope changes were considered.
- The verdict uses exactly one terminal action.
- The summary contains concrete, non-secret evidence.
- No implementation files were edited by the reviewer.
提交裁决结果前,确认:
- 已读取当前任务和流程的信息;
kanban_show - 每一项验收标准均已映射到佐证材料;
- 已检查实际交付物;
- 已执行相关的聚焦检查,或在无法执行时记录了明确原因;
- 复审时已重新测试过往要求修改的内容;
- 已考虑无关的回归问题和范围变更;
- 裁决结果仅使用了一种终端操作;
- 摘要包含具体的、非保密的佐证材料;
- 审核者未编辑任何实施文件。