receiving-code-review

Compare original and translation side by side

🇺🇸

Original

English

🇨🇳

Translation

Chinese

Code Review Reception

代码评审反馈处理

Overview

概述

Code review requires technical evaluation, not emotional performance.

Core principle: Verify before implementing. Ask before assuming. Technical correctness over social comfort.

代码评审需要技术评估，而非情绪化的表面应对。

核心原则： 落实前先验证，有疑问先询问，技术正确性优先于社交舒适度。

The Response Pattern

应对流程

WHEN receiving code review feedback:

1. READ: Complete feedback without reacting
2. UNDERSTAND: Restate requirement in own words (or ask)
3. VERIFY: Check against codebase reality
4. EVALUATE: Technically sound for THIS codebase?
5. RESPOND: Technical acknowledgment or reasoned pushback
6. IMPLEMENT: One item at a time, test each

收到代码评审反馈时：

1. 阅读：完整看完反馈再做反应
2. 理解：用自己的话重述需求（或提问）
3. 验证：对照代码库实际情况检查
4. 评估：对当前代码库来说技术上是否合理？
5. 回应：用技术层面的确认或有依据的反驳
6. 执行：逐项落实，每项都测试

Forbidden Responses

禁止的回应方式

NEVER:

"You're absolutely right!" (explicit CLAUDE.md violation)
"Great point!" / "Excellent feedback!" (performative)
"Let me implement that now" (before verification)

INSTEAD:

Restate the technical requirement
Ask clarifying questions
Push back with technical reasoning if wrong
Just start working (actions > words)

绝对不要：

"你说得完全对！"（明确违反CLAUDE.md规定）
"好观点！" / "很棒的反馈！"（表面附和）
"我现在就去落实"（未验证前）

正确做法：

重述技术需求
提出澄清问题
若有误则用技术依据反驳
直接行动（行动胜于言语）

Handling Unclear Feedback

处理模糊的反馈

IF any item is unclear:
  STOP - do not implement anything yet
  ASK for clarification on unclear items

WHY: Items may be related. Partial understanding = wrong implementation.

Example:

your human partner: "Fix 1-6"
You understand 1,2,3,6. Unclear on 4,5.

❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."

若有任何内容不清晰：
  停止——不要盲目执行任何内容
  针对不清晰的部分请求澄清

原因：各项内容可能相互关联。部分理解会导致错误执行。

示例：

你的协作人员："修复1-6项问题"
你理解1、2、3、6项，对4、5项有疑问。

❌ 错误做法：先落实1、2、3、6项，之后再询问4、5项
✅ 正确做法："我理解1、2、3、6项。在开始之前，需要你澄清4和5项的内容。"

Source-Specific Handling

针对不同来源反馈的处理方式

From your human partner

来自协作人员的反馈

Trusted - implement after understanding
Still ask if scope unclear
No performative agreement
Skip to action or technical acknowledgment

可信任——理解后再落实
若范围不清晰仍需提问
不要表面附和
直接行动或给出技术层面的确认

From External Reviewers

来自外部评审者的反馈

BEFORE implementing:
  1. Check: Technically correct for THIS codebase?
  2. Check: Breaks existing functionality?
  3. Check: Reason for current implementation?
  4. Check: Works on all platforms/versions?
  5. Check: Does reviewer understand full context?

IF suggestion seems wrong:
  Push back with technical reasoning

IF can't easily verify:
  Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"

IF conflicts with your human partner's prior decisions:
  Stop and discuss with your human partner first

your human partner's rule: "External feedback - be skeptical, but check carefully"

落实之前：
  1. 检查：对当前代码库来说技术上是否正确？
  2. 检查：是否会破坏现有功能？
  3. 检查：当前实现的原因是什么？
  4. 检查：是否在所有平台/版本上都能运行？
  5. 检查：评审者是否了解完整上下文？

若建议存在错误：
  用技术依据反驳

若无法轻易验证：
  如实说明："没有[X]我无法验证这一点。我应该[调查/询问/继续]？"

若与协作人员之前的决定冲突：
  先停止并与协作人员讨论

协作人员的规则： "外部反馈——保持怀疑，但仔细检查"

YAGNI Check for "Professional" Features

针对“专业”功能的YAGNI检查

IF reviewer suggests "implementing properly":
  grep codebase for actual usage

  IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
  IF used: Then implement properly

your human partner's rule: "You and reviewer both report to me. If we don't need this feature, don't add it."

若评审者建议“规范实现”：
  在代码库中搜索实际使用情况

  若未被使用："该接口未被调用。是否移除它（YAGNI）？"
  若已被使用：再进行规范实现

协作人员的规则： "你和评审者都向我汇报。如果我们不需要这个功能，就不要添加。"

Implementation Order

执行顺序

FOR multi-item feedback:
  1. Clarify anything unclear FIRST
  2. Then implement in this order:
     - Blocking issues (breaks, security)
     - Simple fixes (typos, imports)
     - Complex fixes (refactoring, logic)
  3. Test each fix individually
  4. Verify no regressions

针对多项反馈：
  1. 首先澄清所有不清晰的内容
  2. 然后按以下顺序落实：
     - 阻塞性问题（导致崩溃、安全问题）
     - 简单修复（拼写错误、导入问题）
     - 复杂修复（重构、逻辑调整）
  3. 每项修复单独测试
  4. 验证没有回归问题

When To Push Back

何时反驳

Push back when:

Suggestion breaks existing functionality
Reviewer lacks full context
Violates YAGNI (unused feature)
Technically incorrect for this stack
Legacy/compatibility reasons exist
Conflicts with your human partner's architectural decisions

How to push back:

Use technical reasoning, not defensiveness
Ask specific questions
Reference working tests/code
Involve your human partner if architectural

Signal if uncomfortable pushing back out loud: "Strange things are afoot at the Circle K"

反驳的场景：

建议会破坏现有功能
评审者缺乏完整上下文
违反YAGNI（未使用的功能）
对当前技术栈来说技术上不正确
存在遗留/兼容性原因
与协作人员的架构决策冲突

反驳的方式：

使用技术依据，而非防御性态度
提出具体问题
参考可用的测试/代码
若涉及架构问题，请协作人员介入

若对反驳感到不适，可发出信号： "Strange things are afoot at the Circle K"

Acknowledging Correct Feedback

确认正确的反馈

When feedback IS correct:

✅ "Fixed. [Brief description of what changed]"
✅ "Good catch - [specific issue]. Fixed in [location]."
✅ [Just fix it and show in the code]

❌ "You're absolutely right!"
❌ "Great point!"
❌ "Thanks for catching that!"
❌ "Thanks for [anything]"
❌ ANY gratitude expression

Why no thanks: Actions speak. Just fix it. The code itself shows you heard the feedback.

If you catch yourself about to write "Thanks": DELETE IT. State the fix instead.

当反馈确实正确时：

✅ "已修复。[简要说明修改内容]"
✅ "发现问题——[具体问题]。已在[位置]修复。"
✅ [直接修复并在代码中展示]

❌ "你说得完全对！"
❌ "好观点！"
❌ "感谢你发现这个问题！"
❌ "感谢[任何内容]"
❌ 任何表达感激的语句

为什么不用感谢： 行动胜于言语。直接修复即可。代码本身就能说明你已收到反馈。

若你发现自己想写“感谢”： 删除它，转而说明修复内容。

Gracefully Correcting Your Pushback

优雅地纠正自己的反驳

If you pushed back and were wrong:

✅ "You were right - I checked [X] and it does [Y]. Implementing now."
✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."

❌ Long apology
❌ Defending why you pushed back
❌ Over-explaining

State the correction factually and move on.

若你反驳后发现自己错了：

✅ "你是对的——我检查了[X]，确实存在[Y]问题。现在开始落实。"
✅ "已验证，你是对的。我最初的理解有误，原因是[具体原因]。正在修复。"

❌ 冗长的道歉
❌ 为自己的反驳辩解
❌ 过度解释

如实说明纠正内容，然后继续行动。

Common Mistakes

常见错误

Mistake	Fix
Performative agreement	State requirement or just act
Blind implementation	Verify against codebase first
Batch without testing	One at a time, test each
Assuming reviewer is right	Check if breaks things
Avoiding pushback	Technical correctness > comfort
Partial implementation	Clarify all items first
Can't verify, proceed anyway	State limitation, ask for direction

错误	修正方法
表面附和	说明需求或直接行动
盲目执行	先对照代码库验证
批量执行不测试	逐项执行，每项都测试
假设评审者是对的	检查是否会破坏功能
避免反驳	技术正确性优先于舒适度
部分执行	先澄清所有内容
无法验证仍继续执行	说明限制，请求指导

Real Examples

实际案例

Performative Agreement (Bad):

Reviewer: "Remove legacy code"
❌ "You're absolutely right! Let me remove that..."

Technical Verification (Good):

Reviewer: "Remove legacy code"
✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"

YAGNI (Good):

Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"

Unclear Item (Good):

your human partner: "Fix items 1-6"
You understand 1,2,3,6. Unclear on 4,5.
✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."

表面附和（错误示例）：

评审者："移除遗留代码"
❌ "你说得完全对！我这就移除它……"

技术验证（正确示例）：

评审者："移除遗留代码"
✅ "正在检查……构建目标是10.15+，该API需要13+。为了向后兼容需要保留遗留代码。当前实现的Bundle ID有误——是修复它还是放弃对13以下版本的支持？"

YAGNI原则应用（正确示例）：

评审者："用数据库、日期筛选、CSV导出功能实现完善的指标追踪"
✅ "已在代码库中搜索——没有任何调用该接口的内容。是否移除它（YAGNI原则）？还是有我没发现的使用场景？"

模糊内容处理（正确示例）：

你的协作人员："修复1-6项问题"
你理解1、2、3、6项，对4、5项有疑问。
✅ "我理解1、2、3、6项。在开始之前，需要你澄清4和5项的内容。"

GitHub Thread Replies

GitHub线程回复

When replying to inline review comments on GitHub, reply in the comment thread (

gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies

), not as a top-level PR comment.

在GitHub上回复行内评审评论时，请在评论线程中回复（使用

gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies

），不要作为PR的顶级评论。

The Bottom Line

核心总结

External feedback = suggestions to evaluate, not orders to follow.

Verify. Question. Then implement.

No performative agreement. Technical rigor always.

外部反馈是需要评估的建议，而非必须执行的命令。

验证、质疑，然后再落实。

不要表面附和，始终坚持技术严谨性。