Code Review

Review Process

Step 1: Run Static Analysis

bin/brakeman
bin/bundler-audit
bundle exec rubocop

Step 2: Analyze Code

1. SOLID Principles — SRP violations, hard-coded conditionals, missing DI
2. Rails Anti-Patterns — Fat controllers/models, N+1 queries, callback hell
3. Security — Mass assignment, SQL injection, XSS, missing authorization
4. Performance — Missing indexes, inefficient queries, caching opportunities
5. Code Quality — Naming, duplication, method complexity, test coverage

Step 3: Structured Feedback

1. Summary: High-level overview
2. Critical Issues (P0): Security, data loss risks
3. Major Issues (P1): Performance, maintainability
4. Minor Issues (P2-P3): Style, improvements
5. Positive Observations: What was done well

Anti-Pattern Examples

# Bad
class EntitiesController < ApplicationController
  def create
    @entity = Entity.new(entity_params)
    @entity.calculate_metrics
    @entity.send_notifications
    if @entity.save then ... end
  end
end

# Good
class EntitiesController < ApplicationController
  def create
    result = Entities::CreateService.call(entity_params)
  end
end

# Bad
@entities.each { |e| e.user.name }

# Good
@entities = Entity.includes(:user)

# Bad
@entity = Entity.find(params[:id])

# Good
@entity = Entity.find(params[:id])
authorize @entity

Review Checklist

• Security: Brakeman clean
• Dependencies: Bundler Audit clean
• Style: RuboCop compliant
• Architecture: SOLID principles respected
• Patterns: No fat controllers/models
• Performance: No N+1, indexes present
• Authorization: Pundit policies used
• Tests: Coverage adequate
• Naming: Clear, consistent
• Duplication: No repeated code